Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please don't change BuddyPress version, leave this task to the BuddyPress core team. #2009

Closed
imath opened this issue Nov 11, 2023 · 2 comments
Assignees

Comments

@imath
Copy link

imath commented Nov 11, 2023

Hi,

I'm one of the lead developers of BuddyPress. I'm kindly asking you to stop modifying the buddypress()->version as you're not the only plugin using it. Could you edit your code and package an update asap?

The buddypress()->version needs to remain a string.

What you are doing here is wrong:
https://github.com/rtCamp/rtMedia/blob/develop/app/main/controllers/template/RTMediaNav.php#L133|L134

Instead, you should do that:

// to solve an issue of Media Tab is not showing in version 10.0.0.
$bp_version = floatval( $bp->version );

if ( isset( $bp_version ) && version_compare( $bp_version, '2.5.3', 'gt' ) ) {

In other words please don't assign a float value to $bp->version, everyone is impacted when you do that.

Thanks in advance to quickly take an action about it.

@pavanpatil1
Copy link
Collaborator

Hi,

Thanks for reporting the issue. Our team is looking into it.

Thanks.

@pavanpatil1 pavanpatil1 assigned Utsav-Ladani and unassigned kjnanda Nov 16, 2023
@pavanpatil1
Copy link
Collaborator

This is fixed and released in the latest version of plugin. Hence closing this issue as done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants