Use better hooks to notify group members they were promoted #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @needle
Just checked, I believe we actually need to update BuddyPress and the BP REST API.
groups_$action_member()function should be usable outside of the Web version using the BP REST API for instance. It's not currently the case and I suspect it to be the reason why we were directly usingBP_Groups_Member->$action()groups_$action_member()functions to be sure cache is cleared or group activities are deleted when it's needed. It's currently not the case. I'll soon submit a PR to the BP REST API GH repo.Trac ticket: https://buddypress.trac.wordpress.org/ticket/9158
This Pull Request is for code review only. Please keep all other discussion in the BuddyPress Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the WordPress Core Handbook for more details.