Dreprecate bp-moment JS dependency in favor of WP’s moment one
#39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thebrandonallen
pushed a commit
to thebrandonallen/buddypress
that referenced
this pull request
Nov 24, 2022
Doing so is taking care of using a fresher version of moment.js (v2.29.4). Props thomaslhotta, dcavins Closes buddypress/buddypress#39 Fixes #8766 git-svn-id: https://buddypress.svn.wordpress.org/trunk@13373 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
dcavins
pushed a commit
to dcavins/buddypress-wp-svn
that referenced
this pull request
Feb 13, 2023
Doing so is taking care of using a fresher version of moment.js (v2.29.4). Props thomaslhotta, dcavins Closes buddypress/buddypress#39 Fixes #8766 git-svn-id: http://buddypress.svn.wordpress.org/trunk@13373 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simply & softly deprecates
bp-momentJS dependency. That being said, asbp-momentis only used bybp-livestampto live update human dates/time diff on the website, we could simply remove this dependency and save ~ 740 KB (see https://github.com/buddypress/buddypress/tree/master/src/bp-core/js/vendor/moment-js). Consequence would be the people using a WordPress version < 5.0 (a very limited population, see https://wordpress.org/about/stats/) would not enjoy this live updating feature anymore..Trac ticket: https://buddypress.trac.wordpress.org/ticket/8766
This Pull Request is for code review only. Please keep all other discussion in the BuddyPress Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the WordPress Core Handbook for more details.