Load Customizer code conditionally #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the Customizer code ran on all pages. The majority of users will never need to load the Customizer code since they do not have access to it. This commit only loads the Customizer code if a user has the 'customize' capability.
|
Ok good point, most of the settings are of or for an elevated user type, but we still load the settings and then check I guess we're saying here rather than simply check first then load? sounds like sensible enhancement, lets merge it - I'll try and run branch later and see if any issues or merge and we'll deal with issue if/when they occur. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the Customizer code ran on all pages. The majority of users will never need to load the Customizer code since they do not have access to it.
This PR only loads the Customizer code if a user has the
customizecapability.Let me know what you think.