Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

button with icon does not show icon #2254

Closed
Leftyx opened this issue Feb 21, 2020 · 8 comments
Closed

button with icon does not show icon #2254

Leftyx opened this issue Feb 21, 2020 · 8 comments
Assignees

Comments

@Leftyx
Copy link

Leftyx commented Feb 21, 2020

Overview of the problem

Buefy version: 0.8.11
Vuejs version: 2.6.11
OS/Browser: ALL

Description

Latest version of Buefy breaks the rendering of a b-button with b-icon inside (I need a button without borders).

<b-button type="is-text">
     <b-icon icon="delete" type="is-success" />
</b-button> 

Steps to reproduce

  1. Open this codepen
  2. Reference latest buefy version 0.8.11 (https://unpkg.com/buefy@0.8.11/dist/buefy.min.js)
  3. Render page

Expected behavior

image

Actual behavior

image

It was working fine until version 0.8.10.

@jtommy jtommy self-assigned this Feb 21, 2020
@jtommy jtommy added the bug label Feb 21, 2020
@service-paradis
Copy link
Collaborator

I had the same problem yesterday having a button that contains only a single HTML element.

<b-button>
  <span>{{ displayedText }}</span>
</b-button>

codepen example

My workaround for those case right now is yo add another empty an not useful element...

<b-button>
  <span>{{ displayedText }}</span><span></span>
</b-button>

@Leftyx
Copy link
Author

Leftyx commented Feb 21, 2020

I can see there are loads of workarounds in place.
I am worried cause every time there is a new version something breaks.

@service-paradis
Copy link
Collaborator

There are 6 workaround right now. Some of them are more related to Bulma than to Buefy. I dont think this is a lot.
Some of them (2 as I know) are already being checked out.

@jtommy
Copy link
Member

jtommy commented Feb 21, 2020

@Leftyx I really apologize it was my fault during an internal test

@Leftyx
Copy link
Author

Leftyx commented Feb 21, 2020

@Leftyx I really apologize it was my fault during an internal test

@jtommy That's ok. I was a little bit annoyed cause my client found the issue so I had to quickly revert the changes.

@jtommy
Copy link
Member

jtommy commented Feb 21, 2020

@Leftyx I know, and i'm sorry but I'll fix it soon

@holtolee
Copy link
Contributor

If you put content in your button with a slot or more complex things like transition it is broken too.

jtommy added a commit that referenced this issue Feb 21, 2020
@jtommy
Copy link
Member

jtommy commented Feb 22, 2020

Close 9b15e7c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants