Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Datetimepicker - Day of week header is one day off #3278

Closed
JeremieDejardin opened this issue Apr 15, 2021 · 0 comments · Fixed by #3289
Closed

Datetimepicker - Day of week header is one day off #3278

JeremieDejardin opened this issue Apr 15, 2021 · 0 comments · Fixed by #3289

Comments

@JeremieDejardin
Copy link

JeremieDejardin commented Apr 15, 2021 •
edited

Overview of the problem

Buefy version: 0.9.4
Vuejs version: 2.9.6
OS/Browser: Chrome Version 89.0.4389.128

Description

A user notified me today that the day of the week display in the calendar of the datepickers was a day off. I checked and confirmed it.
I first checked our config to see if anything was amiss but then went to https://buefy.org/documentation/datetimepicker and saw the same behaviour: When using the date picker, the day of week header is one day off. e.g. Header shows Wednesday for a date that should be Thursday.

Steps to reproduce

  1. Navigate to https://buefy.org/documentation/datetimepicker
  2. Focus on the first datetimepicker.
  3. Look at the display

Expected behaviour

Day of week header to reflect the same day of the week as the user expects.

Actual behaviour

The header shows a day off.
Screenshot 2021-04-15 at 12 08 49
waldeck-dev added a commit to waldeck-dev/buefy that referenced this issue Apr 18, 2021
@waldeck-dev
Fix buefy#3278 Remove timeZone option from DateTimeFormat
54d5aa1 
Signed-off-by: Valentin <valentin@waldeck.dev>
@waldeck-dev waldeck-dev mentioned this issue Apr 18, 2021
Merged
jtommy pushed a commit that referenced this issue Apr 18, 2021
@waldeck-dev
#3278 Fix weekdays off by one day (#3289)
07d9635 
* Remove unecessary docstring - param was removed

Signed-off-by: Valentin <valentin@waldeck.dev>

* Fix #3278 Remove timeZone option from DateTimeFormat

Signed-off-by: Valentin <valentin@waldeck.dev>

* Simplify code

Signed-off-by: Valentin <valentin@waldeck.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#3278 Fix weekdays off by one day waldeck-dev/buefy
1 participant
@JeremieDejardin