New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tooltip - AbortController
is not defined in SSR mode (Nuxt)
#4017
Labels
Comments
mirocklez
changed the title
Tooltip - AbortController in SSR (Nuxt)
Tooltip - AbortController is not defined in SSR mode (Nuxt)
Feb 29, 2024
mirocklez
changed the title
Tooltip - AbortController is not defined in SSR mode (Nuxt)
Tooltip - Feb 29, 2024
AbortController
is not defined in SSR mode (Nuxt)
I have the same problem in my project. |
@miroslavgeorgiev Thanks for reporting an issue. Could you do me a favor; locally build and test if FYI: building
|
Sure - checking the PR :) |
kikuomax
added a commit
that referenced
this issue
Mar 6, 2024
…) (#4019) * fix: Tooltip did not work in SSR due to AbortController Fixes the bug that `Tooltip` did not work in Server Side Rendering (SSR) due to `window.AbortController` use; i.e., no `window` is available in SSR. Moves `window.AbortController` access inside the `window` availability check. * docs: update CHANGELOG Adds unreleased entry for v0.9.29. Lists the fix of the `window.AbortController` use in SSR.
7 tasks
kikuomax
added a commit
to kikuomax/buefy
that referenced
this issue
Apr 2, 2024
…fy#4017) (buefy#4019) * fix: Tooltip did not work in SSR due to AbortController Fixes the bug that `Tooltip` did not work in Server Side Rendering (SSR) due to `window.AbortController` use; i.e., no `window` is available in SSR. Moves `window.AbortController` access inside the `window` availability check. * docs: update CHANGELOG Adds unreleased entry for v0.9.29. Lists the fix of the `window.AbortController` use in SSR.
kikuomax
added a commit
to ntohq/buefy-next
that referenced
this issue
Apr 3, 2024
…fy#4017) (buefy#4019) * fix: Tooltip did not work in SSR due to AbortController Fixes the bug that `Tooltip` did not work in Server Side Rendering (SSR) due to `window.AbortController` use; i.e., no `window` is available in SSR. Moves `window.AbortController` access inside the `window` availability check. * docs: update CHANGELOG Adds unreleased entry for v0.9.29. Lists the fix of the `window.AbortController` use in SSR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Buefy version: [0.9.28]
Nuxt version: [2.17.3]
Description
In the last update of the Tooltip component - there is an addon to remove animation on
beforeDestroy
event.The problem is that it is using
window.AbortController()
without checking arewindow
and/orAbortController
defined.Both of them are not defined when using Nuxt with SSR mode.
Code source
buefy/src/components/tooltip/Tooltip.vue
Line 288 in a13d844
buefy/src/components/tooltip/Tooltip.vue
Line 334 in a13d844
First - when
AbortController
is registered (row 288) in SSR mode it will be just undefined.Second - when using the
abort
method (row 334) without checking it is defined - is causing the error:Expected behavior
Use
AbortController
only after check ifwindow
and/orAbortController
are defined.Actual behavior
AbortController
is used without checking forwindow
object and/orAbortController
instance which cause errors.The text was updated successfully, but these errors were encountered: