Fix: Tooltip - AbortController is not defined in SSR mode (Nuxt) (#4017) #4019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the bug that `Tooltip` did not work in Server Side Rendering (SSR) due to `window.AbortController` use; i.e., no `window` is available in SSR. Moves `window.AbortController` access inside the `window` availability check.
✅ Deploy Preview for buefy-org ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Stays draft until we confirm it works with Nuxt 2. |
Adds unreleased entry for v0.9.29. Lists the fix of the `window.AbortController` use in SSR.
mirocklez
reviewed
Mar 5, 2024
mirocklez
approved these changes
Mar 5, 2024
7 tasks
kikuomax
added a commit
to kikuomax/buefy
that referenced
this pull request
Apr 2, 2024
…fy#4017) (buefy#4019) * fix: Tooltip did not work in SSR due to AbortController Fixes the bug that `Tooltip` did not work in Server Side Rendering (SSR) due to `window.AbortController` use; i.e., no `window` is available in SSR. Moves `window.AbortController` access inside the `window` availability check. * docs: update CHANGELOG Adds unreleased entry for v0.9.29. Lists the fix of the `window.AbortController` use in SSR.
kikuomax
added a commit
to ntohq/buefy-next
that referenced
this pull request
Apr 3, 2024
…fy#4017) (buefy#4019) * fix: Tooltip did not work in SSR due to AbortController Fixes the bug that `Tooltip` did not work in Server Side Rendering (SSR) due to `window.AbortController` use; i.e., no `window` is available in SSR. Moves `window.AbortController` access inside the `window` availability check. * docs: update CHANGELOG Adds unreleased entry for v0.9.29. Lists the fix of the `window.AbortController` use in SSR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
AbortControlleris not defined in SSR mode (Nuxt) #4017Proposed Changes
Tooltip, movewindow.AbortControlleraccess inside thewindowavailability checkcontrollerpossiblynull