Add generic to ColorModifiers type #3636
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
ATM ColorModifiers type will always resolve to
string
because of| string
.This PR will allow to pass custom union to
ColorModifiers
when defining new colors in a project using buefy / bulma, which will make the type more strict and representative of the colors used in your project.As the default type of the generic is string, it will not break existing configurations.
Usage
Not sure if it's the right way to go, or is it better to create a
.d.ts
file directly in your project and overwritting this type as needed ?