Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.9.24 #3878

Merged
merged 16 commits into from Sep 22, 2023
Merged

v0.9.24 #3878

merged 16 commits into from Sep 22, 2023

Conversation

wesdevpro
Copy link
Member

@wesdevpro wesdevpro commented Sep 3, 2023

What's Changed in v0.9.24

julzELO and others added 10 commits March 6, 2023 22:15
* Added mobileModal to Clockpicker Component

* Added mobileModal to Timepicker Component
* feat: 🎸 Adding a new prop to set the id for inner input

Adding a new prop to set the id for inner input for checkbox component

* docs: ✏️ Adding helping data on checkbox api file

* refactor: 💡 Changing prop name
* Fix: Disabled radio button has cursor 'pointer' (#3826)

* Fix: Sidebar image not displaying in the documentation (#3838)
* number input value fix - #3698

* checks fix

---------

Co-authored-by: Amal Mathew <122610766+amal-qb@users.noreply.github.com>
* Numberinput: fix long-press breaking when disabled

* Numberinput: fix long-press unit test
Updated documentation for attribute `auto-close` from #3855
* Fix: Expired and broken websites in expo page (#3780)

* Fix: Full width sidebar doesn't have a close button (#3802)

* Fix: Full width sidebar doesn't have a close button (#3802) - format code

* Fix: Full width sidebar doesn't have a close button (#3802) - Add documentation
- Fixes the bug that `Datepicker` ended up with an infinite loop when a
  user tried to move focus onto an unselectable cell.
@kikuomax kikuomax marked this pull request as draft September 4, 2023 01:51
kikuomax and others added 5 commits September 13, 2023 13:22
…ng the value (#3884) (#3886)

* fix(lib): Input not validate on value prop change

- Fixes the bug that `Input` did not validate an updated value if
  `value` prop was updated from outside; i.e., without user interaction.
  Runs validation whenever `value` is changed from outside. It
  determines the update is from outside if `computedValue` and the new
  value are different. Intentionally uses `!=` instead of `!==`, because
  `computedValue` and `value` may be either string or number.

* test(lib): test validation on Input

- Introduces new test cases for `Input` that test validation runs on
  relevant events:
    - "input" event
    - "change" event
    - `value` prop is programmatically changed

  Also tests cases where the `Input` value has v-model binding. These
  tests make sure that the chain of events won't run validation twice on
  the same value.
…) persists after value is corrected (#3883) (#3885)

* fix(lib): validation error on addons persisted

- Fixes the bug that a validation error on a `Field` that wraps multile
  child components (has addons) persisted. `Field` wraps its slot in
  another `Field` (wrapper) if the slot is consisting of multiple
  components. It used to propagate `newType` to the wrapper, but this
  prevented the type of the wrapper updated once `newType` was set due
  to the line: https://github.com/buefy/buefy/blob/6f41e91bd24dfef8f680f27313e07b488ddcfc1d/src/utils/FormElementMixin.js#L137
  Propagates `type` instead of `newType` to the wrapper.

* test(lib): add test for Field's type

- Adds a new test case for `Field` that tests if `Field` containing
  multiple components (addons) reflects the validation status of a
  wrapped input. This verifies the fix of the bug that `Field` with
  addons did not update its validation status (`newType`) once it was
  set.
* Add nearbyMonthDays prop support to Datetimepicker

Add Datepicker component prop `nearby-month-days` to Datetimepicker component

* FIX lint Datetimepicker.vue

* Use Datepicker default behavior for nearbyMonthDays prop

* Update datetimepicker api doc with nearbyMonthDays prop
* Updated The Documentation's Twitter Link

* Updated Sponsor Links

* Update FUNDING.yml
@netlify
Copy link

netlify bot commented Sep 22, 2023

Deploy Preview for buefy-org ready!

Name Link
🔨 Latest commit 584d1a8
🔍 Latest deploy log https://app.netlify.com/sites/buefy-org/deploys/650e0261c402940008bd4046
😎 Deploy Preview https://deploy-preview-3878--buefy-org.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@wesdevpro wesdevpro self-assigned this Sep 22, 2023
@wesdevpro wesdevpro marked this pull request as ready for review September 22, 2023 21:10
@wesdevpro
Copy link
Member Author

@kikuomax please review the workflow for publishing Buefy to NPM. I have added the special secret to the repository's secrets

@jtommy
Copy link
Member

jtommy commented Sep 22, 2023

It's ok, you need to add a GitHub action to publish the release the new version

@wesdevpro
Copy link
Member Author

It's ok, you need to add a GitHub action to publish the release the new version

I did see 584d1a8

@jtommy
Copy link
Member

jtommy commented Sep 22, 2023

My fault there is already it!

@wesdevpro
Copy link
Member Author

My fault there is already it!

No problem

@wesdevpro wesdevpro merged commit 1c273aa into master Sep 22, 2023
5 checks passed
@wesdevpro
Copy link
Member Author

wesdevpro commented Sep 22, 2023

@jtommy @kikuomax the npm publish workflow worked 😎✨You can see the new version has been uploaded to npm (the version should now be v0.9.24)

@jtommy
Copy link
Member

jtommy commented Sep 22, 2023

Great job, remember to create the release on GitHub too!

https://github.com/buefy/buefy/releases

@wesdevpro
Copy link
Member Author

wesdevpro commented Sep 22, 2023

Great job, remember to create the release on GitHub too!

https://github.com/buefy/buefy/releases

Is there a way to add that to my workflow?

I created a new release targeting master https://github.com/buefy/buefy/releases

@jtommy
Copy link
Member

jtommy commented Sep 22, 2023

https://github.com/oruga-ui/oruga/blob/develop/.github/workflows/publish-release.yml

@wesdevpro
Copy link
Member Author

Oh so you guys get the changes for the body of the release from the change log! cool

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Completed ✅
Development

Successfully merging this pull request may close these issues.

None yet

9 participants