Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Progress bar in Notification component is not showing, when "Programmatically opening" #3855

Closed
johnrusu opened this issue May 13, 2023 · 9 comments
Assignees

Comments

@johnrusu
Copy link

Hello,
I'm using the notification with the progress bar and i noticed that if u use "Programmatically opening", the progress bar will not show

Non-working example:

this.$buefy.notification.open({
                    message: `I can show you a little progress bar displaying the remaining time!`,
                    duration: 5000,
                    progressBar: true,
                    type: 'is-primary',
                    pauseOnHover: true
                })

Thanks!

Buefy version: [0.9.23]
Vuejs version: [2.7.13]
OS/Browser:
Version 113.0.5672.93 (Official Build) (64-bit) Chrome
Version 113.0.1774.35 (Official build) (64-bit) Edge

image

@guestisp
Copy link

Same here

@johnrusu
Copy link
Author

@guestisp
checked the code, apparently u need to use autoClose: true
in Notification.vue

 <b-progress
                v-if="autoClose && progressBar"
                class="auto-close-progress"
                :value="remainingTime - 1"
                :max="duration / 1000 - 1"
                :type="type"
                :rounded="false"/>

Try this:

this.$buefy.notification.open({
                message: `I can show you a little progress bar displaying the remaining time! asdasd`,
                duration: 5000,
                progressBar: true,
                type: "is-primary",
                pauseOnHover: true,
                autoClose: true
            });

@wesdevpro
Copy link
Member

wesdevpro commented Jul 21, 2023

I believe I ran into this issue in the past as well. I will have to check to be sure but I was able to get it working. Too be busy at the moment to test this but if you could send a code pen reducing the issue that would be awesome.

@johnrusu
Copy link
Author

johnrusu commented Jul 21, 2023

@wesdevpro @guestisp
https://codesandbox.io/s/silent-architecture-67498s?file=/src/App.vue
but the api docs for notification for auto-close needs to be changed, cause not it's Hide notification after duration only not programmatic

@wesdevpro
Copy link
Member

wesdevpro commented Jul 21, 2023

@johnrusu You have a working solution using the programmatic method 🤣Let me see what I can do to edit the documentation and remove only not programmatic. I will also take a moment to get with @jtommy to see why this was added to the docs

@guestisp
Copy link

I confirm that adding autoClose: true makes the progressbar visible

@wesdevpro
Copy link
Member

wesdevpro commented Jul 21, 2023

Good deal! I think the best change will be to change the documentation. Hopefully, I will get it done soon.

@johnrusu
Copy link
Author

Thx @wesdevpro

@wesdevpro wesdevpro self-assigned this Jul 21, 2023
wesdevpro added a commit that referenced this issue Jul 23, 2023
Updated documentation for attribute `auto-close` from #3855
wesdevpro added a commit that referenced this issue Jul 23, 2023
Updated documentation for attribute `auto-close` from #3855
@wesdevpro
Copy link
Member

@guestisp @johnrusu The changes have been made! However, they wont show until we make our next pull into master ("main"). I will eventually publish the new changes. Thank you!

wesdevpro added a commit that referenced this issue Sep 22, 2023
* Added mobileModal to Clockpicker Component (#3840)

* Added mobileModal to Clockpicker Component

* Added mobileModal to Timepicker Component

* Input-id prop checkbox 

* feat: 🎸 Adding a new prop to set the id for inner input

Adding a new prop to set the id for inner input for checkbox component

* docs: ✏️ Adding helping data on checkbox api file

* refactor: 💡 Changing prop name

* Fix: Logo not displaying in the Sidebar documentation (#3838) (#3839)

* Fix: Disabled radio button has cursor 'pointer' (#3826)

* Fix: Sidebar image not displaying in the documentation (#3838)

* Fix: Expired and broken websites in expo page (#3780) (#3845)

* Number input null issue fix - #3698 (#3847)

* number input value fix - #3698

* checks fix

---------

Co-authored-by: Amal Mathew <122610766+amal-qb@users.noreply.github.com>

* Numberinput: fix long-press breaking when disabled (#3860)

* Numberinput: fix long-press breaking when disabled

* Numberinput: fix long-press unit test

* Update notification.js (#3867)

Updated documentation for attribute `auto-close` from #3855

* Fix: Full width sidebar doesn't have a close button (#3802) (#3856)

* Fix: Expired and broken websites in expo page (#3780)

* Fix: Full width sidebar doesn't have a close button (#3802)

* Fix: Full width sidebar doesn't have a close button (#3802) - format code

* Fix: Full width sidebar doesn't have a close button (#3802) - Add documentation

* fix: infinite loop on Datepicker (#3877)

- Fixes the bug that `Datepicker` ended up with an infinite loop when a
  user tried to move focus onto an unselectable cell.

* Bump Version From v0.9.23 to v0.9.24

* Fix: Validation error on Input not reset by programmatically correcting the value (#3884) (#3886)

* fix(lib): Input not validate on value prop change

- Fixes the bug that `Input` did not validate an updated value if
  `value` prop was updated from outside; i.e., without user interaction.
  Runs validation whenever `value` is changed from outside. It
  determines the update is from outside if `computedValue` and the new
  value are different. Intentionally uses `!=` instead of `!==`, because
  `computedValue` and `value` may be either string or number.

* test(lib): test validation on Input

- Introduces new test cases for `Input` that test validation runs on
  relevant events:
    - "input" event
    - "change" event
    - `value` prop is programmatically changed

  Also tests cases where the `Input` value has v-model binding. These
  tests make sure that the chain of events won't run validation twice on
  the same value.

* Fix: Validation error on Field with multiple child components (addons) persists after value is corrected (#3883) (#3885)

* fix(lib): validation error on addons persisted

- Fixes the bug that a validation error on a `Field` that wraps multile
  child components (has addons) persisted. `Field` wraps its slot in
  another `Field` (wrapper) if the slot is consisting of multiple
  components. It used to propagate `newType` to the wrapper, but this
  prevented the type of the wrapper updated once `newType` was set due
  to the line: https://github.com/buefy/buefy/blob/6f41e91bd24dfef8f680f27313e07b488ddcfc1d/src/utils/FormElementMixin.js#L137
  Propagates `type` instead of `newType` to the wrapper.

* test(lib): add test for Field's type

- Adds a new test case for `Field` that tests if `Field` containing
  multiple components (addons) reflects the validation status of a
  wrapped input. This verifies the fix of the bug that `Field` with
  addons did not update its validation status (`newType`) once it was
  set.

* Add nearbyMonthDays prop support to Datetimepicker (#3881)

* Add nearbyMonthDays prop support to Datetimepicker

Add Datepicker component prop `nearby-month-days` to Datetimepicker component

* FIX lint Datetimepicker.vue

* Use Datepicker default behavior for nearbyMonthDays prop

* Update datetimepicker api doc with nearbyMonthDays prop

* Update Twitter and Sponsor Links (#3888)

* Updated The Documentation's Twitter Link

* Updated Sponsor Links

* Update FUNDING.yml

* Update Package Json

* Add Workflow to Publish Buefy on PR to Master

---------

Co-authored-by: julzELO <73643910+julzELO@users.noreply.github.com>
Co-authored-by: Aarón J. Montes <32050436+ajomuch92@users.noreply.github.com>
Co-authored-by: Amal Mathew <122610766+amal-qb@users.noreply.github.com>
Co-authored-by: navedqb <109583873+navedqb@users.noreply.github.com>
Co-authored-by: Sylvain Marty <10723351+SylvainMarty@users.noreply.github.com>
Co-authored-by: Kikuo Emoto <kemoto@codemonger.io>
Co-authored-by: Guillaume Mercey <guillaume.mercey@gmail.com>
kikuomax pushed a commit to kikuomax/buefy that referenced this issue Jan 10, 2024
Updated documentation for attribute `auto-close` from buefy#3855
kikuomax pushed a commit to kikuomax/buefy that referenced this issue Feb 11, 2024
Updated documentation for attribute `auto-close` from buefy#3855
kikuomax pushed a commit to ntohq/buefy-next that referenced this issue Feb 12, 2024
Updated documentation for attribute `auto-close` from buefy#3855
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Completed ✅
Development

No branches or pull requests

3 participants