Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type="button" to buttons to prevent submit #53

Merged
merged 3 commits into from
May 8, 2017

Conversation

shentao
Copy link

@shentao shentao commented May 8, 2017

Otherwise, it breaks usage within <form> elements due to automatically triggering the form submit.

Damian Dulisz added 3 commits May 8, 2017 17:35
Otherwise, it breaks usage within `<form>` elements due to automatically triggering the form submit.
@shentao shentao changed the title Add type="button" to button within notifications Add type="button" to buttons to prevent submit May 8, 2017
@rafaberaldo rafaberaldo merged commit 10e99a9 into buefy:dev May 8, 2017
@rafaberaldo
Copy link
Member

Thank you

@shentao
Copy link
Author

shentao commented May 9, 2017

Sure thing! Thanks for this amazing library. :D

kikuomax added a commit to kikuomax/buefy that referenced this pull request Sep 4, 2023
* test(lib): update CheckRadioMixin spec

- Updates the unit tests (spec) of `CheckRadioMixin` so that they can
  work with Vue 3 and `@vue/test-utils` V2:
    - Awaits `wrapper.setProps` to make sure that the subsequent tests
      verify new props.
    - Corrects v-model binding: `value` → `modelValue`
    - Replaces `attachToDocument: true` in the option for `shallowMount`
      with `attachTo: document.body`, because `attachToDocument` no
      longer exists in V2.

issue ntohq#1

* test(lib): move mixins option (CheckRadioMixin)

- Moves `mixins` option from `shallowMount` to the definition of the
  component to be tested because the behavior is equivalent and less
  obscure.

issue ntohq#1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants