Fix issue where all files were being iterated over when using path fi…

…ltering (#2337)

CHANGELOG.md

@@ -2,6 +2,7 @@
 
 ## [Unreleased]
 
+- Fix issue where all files were being iterated over when using the `--path` flag.
 - Fix issue where the directory `.` was incorrectly accepted as a value for the
   `directories` key in `buf.work.yaml`.
 

private/bufpkg/bufmodule/bufmodulebuild/module_file_set_builder.go

@@ -156,7 +156,12 @@ func (m *moduleFileSetBuilder) build(
 
 // protoPathsHash returns a hash representing the paths of the .proto files within the Module.
 func protoPathsHash(ctx context.Context, module bufmodule.Module) (string, error) {
-	fileInfos, err := module.SourceFileInfos(ctx)
+	// Use TargetFileInfos instead of SourceFileInfos as otherwise this will iterate over
+	// all files in a bucket in the case of using i.e. --path, which causes massive performance problems.
+	//
+	// If you are targeting a specific set of files, it's fair to have our duplication detection only
+	// use target files.
+	fileInfos, err := module.TargetFileInfos(ctx)
 	if err != nil {
 		return "", err
 	}