Add go app that updates changelog automatically #1872
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elliotmjackson
approved these changes
Feb 28, 2023
bufdev
reviewed
Mar 3, 2023
bufdev
reviewed
Mar 23, 2023
| } | ||
|
|
||
| func unrelease(data []byte, repo string) []byte { | ||
| re := regexp.MustCompile(`# Changelog`) |
There was a problem hiding this comment.
MustCompile will panic, should get the error and handle it
There was a problem hiding this comment.
We already use static regexps in global vars, is this okay? having a block like this:
var (
lastLinkRegexp = regexp.MustCompile(fmt.Sprintf(`\[v%s\].*?v%s\.\.\.v%s`, semverRegex, semverRegex, semverRegex))
headerRegexp = regexp.MustCompile(`# Changelog`)
unreleasedHeaderRegexp = regexp.MustCompile(fmt.Sprintf(`\[Unreleased\]: (.*?)v%s\.\.\.HEAD`, semverRegex))
unreleasedLinkRegexp = regexp.MustCompile(`## \[Unreleased\]`)
repoRegexp = regexp.MustCompile(`\[.*?]: (.*?)\/compare`)
)
seems to be reasonable to me because it's never going to change?
|
|
||
| const semverRegex = `((0|[1-9]\d*)\.(0|[1-9]\d*)\.(0|[1-9]\d*)(?:-((?:0|[1-9]\d*|\d*[a-zA-Z-][0-9a-zA-Z-]*)(?:\.(?:0|[1-9]\d*|\d*[a-zA-Z-][0-9a-zA-Z-]*))*))?(?:\+([0-9a-zA-Z-]+(?:\.[0-9a-zA-Z-]+)*))?)` | ||
|
|
||
| func main() { |
There was a problem hiding this comment.
generally we'd do if err := run(); err != nil style, grep the codebase for examples
|
|
added 3 commits
June 23, 2023 17:17
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updatechangelog unrelease CHANGELOG.md: addsUnreleasedsection into CHANGELOG.mdupdatechangelog --version=v1.17.0 release CHANGELOG.md: removesUnreleasedsections from CHANGELOG.md and adds thev1.17.0into the changelog, including the links: