Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add examples + ecosystem sections to README #43

Merged
merged 2 commits into from
Jun 30, 2023

Conversation

jchadwick-buf
Copy link
Member

No description provided.

@jchadwick-buf jchadwick-buf changed the base branch from jchadwick/fix-tls to main June 29, 2023 18:59
@jchadwick-buf jchadwick-buf requested a review from jhump June 29, 2023 20:34
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Comment on lines +91 to +93
## Ecosystem

* [connect-go](https://github.com/bufbuild/connect-go): RPC library, compatible with `httplb`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this section useful? I think you could just add a link to the connect-go repo above, where you have code examples using Connect.

Copy link
Member Author

@jchadwick-buf jchadwick-buf Jun 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wasn't my idea, was Marek's. Maybe we should ask him for clarification. (sent him a DM, ill get back to this.)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we can merge as is. Not my favorite way to link the repos together, but whatev...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I dunno. Perhaps not ideal, but alas. It can always be iterated on.

README.md Show resolved Hide resolved
@jchadwick-buf jchadwick-buf merged commit eebe28f into main Jun 30, 2023
3 checks passed
@jchadwick-buf jchadwick-buf deleted the jchadwick/readme-examples branch June 30, 2023 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants