Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add roadrunner-server php-grpc plugin #656

Merged
merged 3 commits into from
Jul 12, 2023
Merged

Add roadrunner-server php-grpc plugin #656

merged 3 commits into from
Jul 12, 2023

Conversation

pkwarren
Copy link
Member

Fixes #655.

@pkwarren pkwarren requested a review from mfridman July 12, 2023 20:42
mfridman
mfridman approved these changes Jul 12, 2023
View reviewed changes
Copy link
Member

@mfridman mfridman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great job @pkwarren, some folks are going to be very happy (assuming the latest and greatest version is good enough).

@pkwarren pkwarren merged commit 73c9901 into main Jul 12, 2023
3 checks passed
@pkwarren pkwarren deleted the pkw/rr-php-grpc branch July 12, 2023 22:10
@pkwarren pkwarren mentioned this pull request Sep 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfridman mfridman mfridman approved these changes

@rustatian rustatian Awaiting requested review from rustatian

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Plugin request for Buf Schema Registry: RoadRunner protoc-gen-php-grpc plugin
3 participants
@pkwarren @mfridman @rustatian