Fix tsconfig for protoc-gen-es (#767)

bufbuild · Apr 2, 2024 · 2b2861b · 2b2861b
1 parent bc67371
commit 2b2861b
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 3 deletions.
diff --git a/packages/protoc-gen-es/package.json b/packages/protoc-gen-es/package.json
@@ -16,7 +16,7 @@
   },
   "scripts": {
     "clean": "rm -rf ./dist/cjs/*",
-    "build": "../../node_modules/typescript/bin/tsc --project tsconfig.json --module commonjs --verbatimModuleSyntax false --moduleResolution node10 --outDir ./dist/cjs"
+    "build": "../../node_modules/typescript/bin/tsc --project tsconfig.json --outDir ./dist/cjs"
   },
   "preferUnplugged": true,
   "dependencies": {

diff --git a/packages/protoc-gen-es/tsconfig.json b/packages/protoc-gen-es/tsconfig.json
@@ -2,6 +2,11 @@
   "files": ["src/protoc-gen-es-plugin.ts"],
   "extends": "../../tsconfig.base.json",
   "compilerOptions": {
-    "resolveJsonModule": true
+    // We import the plugin's version number from package.json
+    "resolveJsonModule": true,
+    // This package is CommonJS
+    "verbatimModuleSyntax": false,
+    "module": "CommonJS",
+    "moduleResolution": "Node10"
   }
 }
diff --git a/packages/protoplugin-example/tsconfig.json b/packages/protoplugin-example/tsconfig.json
@@ -2,7 +2,7 @@
   "include": ["src/**/*.ts", "test/*.ts"],
   "compilerOptions": {
     "target": "es2017",
-    "moduleResolution": "Node",
+    "moduleResolution": "Node10",
     "esModuleInterop": false,
     "resolveJsonModule": true,
     "strict": true,