Update buf.lock for protovalidate-testing #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
protovalidate-testing requires the new FloatRules.finite field to compile, so we need to update the buf.lock file to include it.
pkwarren
commented
Jul 20, 2023
| @@ -4,5 +4,5 @@ deps: | |||
| - remote: buf.build | |||
| owner: bufbuild | |||
| repository: protovalidate | |||
| commit: 890d7e3584ce4bb29af9fe953393a3a2 | |||
| digest: shake256:878c6bf315f37310a6315de26f409548d2951b9f8f042a8a599973496fd0298680554dba152924264b9c41f5bd05adbc4b3fcedfc2156e1707006f45fddd9db0 | |||
| commit: f9bf3460ccf141d68ba17653f5ef85dc | |||
There was a problem hiding this comment.
Confirmed this commit has finite: https://buf.build/bufbuild/protovalidate/docs/f9bf3460ccf141d68ba17653f5ef85dc:buf.validate#buf.validate.FloatRules
rodaine
approved these changes
Jul 20, 2023
igor-tsiglyar
pushed a commit
to igor-tsiglyar/protovalidate
that referenced
this pull request
Apr 16, 2024
…ion types (bufbuild#57) The go proto library struggles to resolve values for extensions if the concrete type associated with the generated source code on hand does not match that on the descriptor of the message in question (which happens in cases where the descriptor or message is produced at runtime). This manifested in the protovalidate resolver where the extension could not be found on options attached to a descriptor produced dynamically. Unfortunately, I struggled to find a way to get the extension and its value directly. (I'm not even sure how to get the field/ext descriptor from the descriptor; `protoreflect.Fields.ByNumber` doesn't work). The most straightforward solution from a few iterations was to leverage `proto.RangeExtensions`. There's room here for some mild optimization to short circuit in most vanilla situations but it makes it a bit less readable. Since this only happens once per descriptor, the optimization is overkill IMO.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
protovalidate-testing requires the new FloatRules.finite field to compile, so we need to update the buf.lock file to include it.