Do not abort when interfaces are older than expected #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Not aborting definitely sounds like a good idea 🙂, but I don't think we should print a warning either, since it's not fatal and not something that the user can be expected to do anything about. If the version is too old, we should just treat the global as of it wasn't present. |
nt8r
force-pushed
the
wl-interface-versions
branch
from
ede0811
to
be07cbd
Compare
Instead, let consumers abort if the missing interface is a fatal problem.
nt8r
force-pushed
the
wl-interface-versions
branch
from
be07cbd
to
fcde402
Compare
|
I've removed the printing of a warning. |
|
Thanks, merged (with a follow-up fix 8dbdefb). Please let me know whether things still work on your end 🙂 |
algitbot
pushed a commit
to alpinelinux/aports
that referenced
this pull request
Aug 26, 2023
Patches are picked from upstream: bugaevc/wl-clipboard#193 Fixes #15222
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead, print a warning and let consumers abort if the missing interface is a fatal problem.
This happens with phosh 0.30, for example, which exposes
gtk_shell1version 3. As of this patch, wl-clipboard works again but now printswarning: interface gtk_shell1 wanted version 4 but got version 3to standard error in this situation.