Add options for env, startedBy and region and add a trap for SIGINT #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and add --region, --started-by and --env
Add new options and SIGINT handling
|
Hi Johannes, Thank you for your contributions! Sorry I didn't see this PR earlier. At a quick glance there's only one non style related change i'd like to see, and i'll comment on the specify line re that change. Style wise I'm not a fan of multi line variable declarations with a single Thanks, |
coen-hyde
requested changes
Jan 12, 2018
index.js
Outdated
| var stream = combiner(logs, formatter); | ||
| stream.logStream = logs; | ||
|
|
||
| process.on('SIGINT', () => { |
There was a problem hiding this comment.
Listening for the interrupt signal should probably happen in the ./bin/ecs-task-runner script. Since this index.js is intended to be used for module use.
|
Hi Coen,
Sorry for my late reply and thank you for getting back to me. I think your comments make perfect sense and I’m happy to adjust the PR.
I’ll try to get to it asap. Will ping you once it is updated.
Thanks
Johannes Vetter | Lead Engineer
johannes@art19.com <mailto:johannes@art19.com>
ART19, Inc. • 13261 Moorpark St Suite 104 • Sherman Oaks CA 91423 • 866.882.7819 <tel://415.423.3583> • www.art19.com <http://www.art19.com/>
This email and any attachments thereto may contain private, confidential, and privileged material for the sole use of the intended recipient. Any review, copying, or distribution of this email (or any attachments thereto) by others is strictly prohibited. If you are not the intended recipient, please contact the sender immediately and permanently delete the original and any copies of this email and any attachments thereto.
… Am 12.01.2018 um 14:40 schrieb Coen Hyde ***@***.***>:
Hi Johannes,
Thank you for your contributions! Sorry I didn't see this PR earlier. At a quick glance there's only one non style related change i'd like to see, and i'll comment on the specify line re that change. Style wise I'm not a fan of multi line variable declarations with a single var or const. Can we update the ESLint rules to enforce const variable=value; style?
Thanks,
Coen
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#1 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABGBDU19Vp6k-WGeDRp_Q9ylRVWAR2Wsks5tJ99cgaJpZM4RSYTp>.
|
coen-hyde
approved these changes
Jun 8, 2018
|
Hey @johvet, sorry I missed this. These are some good changes. Merging and releasing a new version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.