Workaround redcarpet formatting issues #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Buildkite uses redcarpet to render the markdown and redcarpet has some issues with nested html block elements. Basically if you have:
Redcarpet thinks the first
</details>is the end of the HTML content and parses everything after that as markdown, causing formatting issues. The easiest solution I can see is to indent the nested content but (a)hamlno longer supports pretty formatting the output and (b) we can't just blindly indent all the contents because of the<pre>elements. So this indents just the nested</details>lines which is a dodgy hack but it works so /shrug.