Fix bin/run-dev to work with the new array syntax #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adbae07#diff-3878fe724c648fb7c135242c7f570c05 broke the run-dev script, because `step['plugins']` is now no longer a hash, but an array of hashes.
tessereth
approved these changes
Jan 27, 2019
There was a problem hiding this comment.
Thanks for fixing this! Sorry for the delay. Checking out the generated html files, it looks like buildkite has moved one of their css files, breaking the template (which is not overly surprising). Just in case you haven't found them yet, I'll fix that shortly.
|
Thank you :) I hadn't noticed the CSS issue, because I only had a look at the raw generated HTML - thanks for looking into it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adbae07 broke the run-dev script, because
step['plugins']is now no longer a hash, but an array of hashes.