Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for windows building #42

Merged
merged 2 commits into from
Jan 25, 2022
Merged

Fix for windows building #42

merged 2 commits into from
Jan 25, 2022

Conversation

ericfialkowski
Copy link
Contributor

This PR contains the fixes for building on windows

@ericfialkowski ericfialkowski mentioned this pull request Jan 25, 2022
Closed
@ericfialkowski
Copy link
Contributor Author

ericfialkowski commented Jan 25, 2022 •
edited

Fixes the issue reported in: #39

@buger
Copy link
Owner

buger commented Jan 25, 2022

Thanks!

@buger buger merged commit a73545a into buger:master Jan 25, 2022
@thaJeztah
Copy link

@buger would it be possible to tag a v1.0.4 with this fix? Thanks!

@ericfialkowski
Copy link
Contributor Author

@buger - could we get this tagged please and thank you.

@buger
Copy link
Owner

buger commented Feb 3, 2022

Sorry for delay!

https://github.com/buger/goterm/releases/tag/v1.0.4

@thaJeztah
Copy link

Thank you!!

@thaJeztah thaJeztah mentioned this pull request Feb 3, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ericfialkowski @buger @thaJeztah