buglabs-osgi: code cleanup

buglabs · Jul 28, 2011 · 07befda · 07befda
1 parent c533cf3
commit 07befda
Showing 1 changed file with 19 additions and 12 deletions.
diff --git a/com.buglabs.common/com/buglabs/util/osgi/LogServiceUtil.java b/com.buglabs.common/com/buglabs/util/osgi/LogServiceUtil.java
@@ -41,8 +41,13 @@
  * @author kgilmer
  * 
  */
-public class LogServiceUtil {
+public final class LogServiceUtil {
 
+	/**
+	 * Utility class.
+	 */
+	private LogServiceUtil() {
+	}
 	/**
 	 * @param context
 	 *            if context is null, it will return a log service that uses
@@ -80,7 +85,8 @@ public void log(int level, String message, Throwable exception) {
 				public void log(ServiceReference sr, int level, String message) {
 					System.out.println(levelString(level) + "Service Reference: " + sr.toString() + " " + message);
 					if (level == LogService.LOG_ERROR) {
-						System.err.println(levelString(level) + "Service Reference: " + sr.toString() + " " + message);
+						System.err.println(levelString(level) + "Service Reference: " 
+								+ sr.toString() + " " + message);
 					}
 				}
 
@@ -123,39 +129,40 @@ private String levelString(int level) {
 	/**
 	 * Log a bundle exception and print nested exception if it exists.
 	 * 
-	 * @param logService
-	 * @param message
-	 * @param exception
+	 * @param logService LogService
+	 * @param message message
+	 * @param exception Exception to log
 	 */
 	public static void logBundleException(LogService logService, String message, BundleException exception) {
 		// Add error handling to be specific about what exactly happened.
 		logService.log(LogService.LOG_ERROR, message + ": " + exception.getMessage() + "\n" + stackTraceToString(exception));
 		stackTraceToString(exception);
 
 		if (exception.getNestedException() != null) {
-			logService.log(LogService.LOG_ERROR, "Nested Exception: " + exception.getNestedException().getMessage() + "\n" + stackTraceToString(exception.getNestedException()));
+			logService.log(LogService.LOG_ERROR, "Nested Exception: " + exception.getNestedException().getMessage() 
+					+ "\n" + stackTraceToString(exception.getNestedException()));
 		}
 	}
 
 	/**
 	 * Log an exception and print nested exception if it exists.
 	 * 
-	 * @param logService
-	 * @param message
-	 * @param exception
+	 * @param logService LogService
+	 * @param message message
+	 * @param exception Exception to log
 	 */
 	public static void logBundleException(LogService logService, String message, Exception exception) {
 		// Add error handling to be specific about what exactly happened.
 		logService.log(LogService.LOG_ERROR, message + ": " + exception.getMessage() + "\n" + stackTraceToString(exception));
 	}
 
 	/**
-	 * @param t
+	 * @param throwable Throwable
 	 * @return A stack trace as a string.
 	 */
-	private static String stackTraceToString(Throwable t) {
+	private static String stackTraceToString(Throwable throwable) {
 		StringWriter sw = new StringWriter();
-		t.printStackTrace(new PrintWriter(sw));
+		throwable.printStackTrace(new PrintWriter(sw));
 		return sw.getBuffer().toString();
 	}
 }