This repository has been archived by the owner on Jan 7, 2021. It is now read-only.
add sanitize options for toXml function. (& -> &, etc.) #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (json instanceof Buffer) { | ||
| json = json.toString(); | ||
| } | ||
|
|
||
| options = { |
There was a problem hiding this comment.
Do you really need it to be global?
There was a problem hiding this comment.
options? no. I just use the same style as in xml2json.js file.
|
thanks for your PR!. I will be looking into this as soon as I can. |
|
I also need this feature. I just created a issue before I noted this PR... |
|
👍 Do want this merged please! |
|
@brutalhonesty I will review again today, fix conflicts and merge. |
|
@c4milo Thanks for the quick response! :) |
|
@brutalhonesty done. I will publish a new version to npm soon. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed to put '&' into the XML file in the entity form (&). The same sanitize function as in toJson function is used to achieve the result.
Second reason:
The options for toXml function were not used (resulted in [Object object] at the beginning of XML file, if you tried to use them), fixed README.