Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): Enable e2e tests #104

Merged
merged 12 commits into from
Apr 11, 2018
Merged

Conversation

kattrali
Copy link
Contributor

@kattrali kattrali commented Apr 9, 2018

Made a start. Having some issues with npm and something else which doesn't seem to be in the logs on the NDK side.

@fractalwrench
Copy link
Contributor

React Native now works.

The NDK is failing due to CI using an older NDK version (13) which does not support unified headers. This results in an exception being thrown when finding the objdump executable, and means SO maps aren't generated/uploaded. From what I remember this was necessary to get NDK uploads working with AGP 3.

The fix for CI would presumably be to update our NDK fork to a later version.

@fractalwrench
Copy link
Contributor

Everything passes now. I've updated the NDK scenario so that it only builds certain ABIs, and altered travis to use an NDK installed via the standard sdkmanager tool.

I also needed to make a small change to the plugin itself, from process.exitValue() to process.waitFor(), which blocks until the process has completed. On CI the objdump process was not completing in time for the SO mapping file to be uploaded, which I believe is a bug. I don't think that most users would run into this issue on a regular developer machine.

@fractalwrench fractalwrench requested a review from a team April 11, 2018 14:51
@fractalwrench fractalwrench merged commit faab520 into add-maze-harness Apr 11, 2018
@fractalwrench fractalwrench deleted the kattrali/enable-e2e-ci branch April 11, 2018 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants