Gradle 4.8-rc-1 compat fix - use def when finding the buildType

[fractalwrench]

Goal

Gradle 4.8-rc-1 changes project.android.buildTypes.store to return an Iterable rather than a Set, which can lead to a runtime error within the plugin. This changeset prevents the runtime error by using def instead.

Changeset

Changed

Altered affected types from specific Set implementation to def.

Tests

Mazerunner was run locally after running ./gradlew wrapper --gradle-version 4.8-rc-1 in each of the fixture projects.

Discussion

Alternative Approaches

We could use Iterable instead of def.

Linked issues

#109

Review

For the submitter, initial self-review:

• Commented on code changes inline explain the reasoning behind the approach
• Reviewed the test cases added for completeness and possible points for discussion
• A changelog entry was added for the goal of this pull request
• Check the scope of the changeset - is everything in the diff required for the pull request?
• This pull request is ready for:
  • Initial review of the intended approach, not yet feature complete
  • Structural review of the classes, functions, and properties modified
  • Final review

For the pull request reviewer(s), this changeset has been reviewed for:

• Consistency across platforms for structures or concepts added or modified
• Consistency between the changeset and the goal stated above
• Internal consistency with the rest of the library - is there any overlap between existing interfaces and any which have been added?
• Usage friction - is the proposed change in usage cumbersome or complicated?
• Performance and complexity - are there any cases of unexpected O(n^3) when iterating, recursing, flat mapping, etc?
• Concurrency concerns - if components are accessed asynchronously, what issues will arise
• Thoroughness of added tests and any missing edge cases
• Idiomatic use of the language

[artem-zinnatullin]

haha, Groovy is helpful sometimes right

[kattrali]

Looks good to me, I'm unsure what's up with the CI suite though.

[kattrali]

This summary seems unclear. It should say is happening from a user perspective, e.g. "Add compatibility with Gradle 4.8-rc1"

[fractalwrench]

Looks like whatever is wrong with CI is wrong on master also.