Improve support for Dexguard APK splits #117
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
DexGuard can generate different mapping files for variantOutputs, which is not taken into consideration by the Android Gradle Plugin. This changeset allows the Bugsnag plugin to calculate the location of a DexGuard mapping file if DexGuard is applied in a project with APK splits enabled.
Changeset
variantOutput.dirName
variantOutput.dirName
and removing density portion of path (if present)Tests
Added mazerunner scenarios to a separate DexGuard test repository, and ran existing mazerunner scenarios. Ensured that no error messages were logged regarding to the AndroidManifest or mapping file not being found for any scenario.
Review
For the submitter, initial self-review:
For the pull request reviewer(s), this changeset has been reviewed for: