Close IO streams after the plugin has finished reading and writing

[fractalwrench]

Goal

Closes IO streams after the plugin has finished reading and writing, in a finally block, which is guaranteed to be executed last.

Changeset

• Altered existing use of Closeable values so that close is called in a try-finally block.
• Added catch block where this was previously missing, that logs a warning

Tests

Ran mazerunner scenarios.

Review

For the submitter, initial self-review:

• Commented on code changes inline explain the reasoning behind the approach
• Reviewed the test cases added for completeness and possible points for discussion
• A changelog entry was added for the goal of this pull request
• Check the scope of the changeset - is everything in the diff required for the pull request?
• This pull request is ready for:
  • Initial review of the intended approach, not yet feature complete
  • Structural review of the classes, functions, and properties modified
  • Final review

For the pull request reviewer(s), this changeset has been reviewed for:

• Consistency across platforms for structures or concepts added or modified
• Consistency between the changeset and the goal stated above
• Internal consistency with the rest of the library - is there any overlap between existing interfaces and any which have been added?
• Usage friction - is the proposed change in usage cumbersome or complicated?
• Performance and complexity - are there any cases of unexpected O(n^3) when iterating, recursing, flat mapping, etc?
• Concurrency concerns - if components are accessed asynchronously, what issues will arise
• Thoroughness of added tests and any missing edge cases
• Idiomatic use of the language

[artem-zinnatullin]

ah I see 👍

[kattrali]

Shouldn't there be a null check here, in case the writer was not initialized?

[fractalwrench]

Good catch, I've updated this to include a null check.

[Pezzah]

Should we also close this reader https://github.com/bugsnag/bugsnag-android-gradle-plugin/pull/126/files#diff-ff274d12fbfb73a5d6888d7dc318c167R72

[fractalwrench]

Thanks, good catch! I've updated the PR to close the additional reader.

addressed review comments