[PIPE-1131] Zip shared object mapping files #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pezzah
changed the title
|
|
||
| return true | ||
| zipStream.close() | ||
| stdout.close() |
There was a problem hiding this comment.
it'd be good to close this in a finally block (there's an open PR which cleans this up generally across the plugin)
| } catch (IOException e) { | ||
| project.logger.error("failed to write symbols for " + arch + ": " + e.getMessage()) | ||
| return false | ||
| byte[] buffer = new byte[1024]; |
There was a problem hiding this comment.
BufferedOutputStream defaults to 8192, we could probably increase this to speed up IO
loopj
reviewed
Aug 24, 2018
| @@ -122,7 +123,7 @@ class BugsnagUploadNdkTask extends BugsnagMultiPartUploadTask { | |||
| outputDir.mkdir() | |||
| } | |||
|
|
|||
| File outputFile = new File(outputDir, arch + ".txt") | |||
| File outputFile = new File(outputDir, arch + ".gzip") | |||
There was a problem hiding this comment.
[Nitpick] .gz is the typical file extension for gzipped files
Pezzah
changed the title
Roll forward in release commit
kattrali
approved these changes
Aug 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Zip shared object mapping files before sending, to reduce transfer time. Also don't process the file as zipping is very effective
This coresponding PR is required to process the zipped files
https://github.com/bugsnag/bugsnag-event-worker/pull/1043
Design
See ROAD-570 design for reasons for the approach