Support automatic upload when building App Bundles #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hich supports App Bundles
… behaviour for App bundles
The task for generating an Android Bundle is distinct from the assemble task, meaning that mapping files are not uploaded automatically. This alters the plugin to depend on the bundle task for proguard/ndk/releases tasks.
fractalwrench
changed the title
Pezzah
reviewed
Dec 11, 2018
| * | ||
| * E.g. [bundle, bundleRelease, bundleFooRelease] | ||
| */ | ||
| private static Set<String> findTaskNamesForPrefix(BaseVariantOutput output, String prefix) { | ||
| String variantName = output.name.split("-")[0].capitalize() | ||
| String assembleTaskName = output.assemble.name |
There was a problem hiding this comment.
It's a shame we can't get the "bundle" task from the build variant instead of using the assemble one and replacing the names.
Pezzah
approved these changes
Dec 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
v3.2.0 of the Android Gradle Plugin (AGP) introduced App Bundles, a new upload format which delegates the generation of APKs to the Google Play store, and which allows dynamic delivery of feature module APKs.
The task used to generate the App Bundle does not trigger the Bugsnag plugin's mapping file upload or build API tasks automatically - this changeset fixes that.
Changeset
The changes are best viewed by looking at the individual commits:
The mazerunner example app fixture was updated to use AGP v3.2.1 to enable building App Bundles. This upgrade also required updating the gradle wrapper for the fixture to 4.6 (the minimum supported), and explicitly stating that all ABIs should be built (mips, mips64, and armeabi were disabled by default in v3.2.0).
Mazerunner scenarios were added for several App Bundle project setups:
These scenarios are broadly the same as the ones used to test
assembletasks.assembletasks was updated to also includebundletasks. This in turn adds a task dependency between eachbundletask and our upload tasks which ensures they automatically run.For example, in our previous gradle plugin, the following tasks would be expected to trigger a mapping file upload, NDK upload, and Build API request:
whereas with these changes, the following tasks would also trigger this behaviour:
Tests
In addition to existing and new mazerunner scenarios, I confirmed that a crash from an APK generated from a bundle deobfuscates correctly on the dashboard. A guide on how to achieve this is available here: https://developer.android.com/guide/app-bundle/
Linked issues
Fixes #135