Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail on upload error #151

Merged
merged 9 commits into from
Mar 13, 2019
Merged

Fail on upload error #151

merged 9 commits into from
Mar 13, 2019

Conversation

fractalwrench
Copy link
Contributor

Goal

Adds mazerunner scenarios to verify the changes within #150, which fails the build if a mapping file upload task was not successful.

Changeset

  • Includes the implementation from Be aware of errors during mapping uploads #150
  • Sets failOnUploadError to true by default
  • Fails the build if an API key is empty, in addition to null, during an upload task
  • If a build variant does not have obfuscation enabled via minifyEnabled and has not applied the DexGuard plugin, the previous behaviour was to create an upload task that failed as there would be no mapping file. This task will no longer be created.

Tests

  • Added mazerunner steps which check the exit code of a script, and for running a script that is expected to exit with a non-zero exit code
  • Created mazerunner scenarios where the build is expected to fail due to:
    • an empty API key
    • using the wrong endpoint
    • a missing mapping file
  • Created mazerunner scenarios where the build is expected to pass due to:
    • Uploading in a default app, with an API key, mapping file, and correct endpoint specified
    • Deobfuscation being disabled, therefore the plugin would not need to upload any mapping files

@fractalwrench fractalwrench changed the base branch from master to next March 13, 2019 09:15
@fractalwrench
Copy link
Contributor Author

Thanks for the review comments @Cawllec - I've addressed the feedback.

Copy link
Contributor

@Cawllec Cawllec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fractalwrench fractalwrench merged commit f9a51af into next Mar 13, 2019
@fractalwrench fractalwrench deleted the fail-on-upload-error branch March 13, 2019 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants