Disable proguard mapping task setup when variant does not obfuscate #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Currently the plugin does not setup any tasks if ProGuard/DexGuard is disabled. This prevents the upload of NDK symbols/release information if a user has a project without obfuscation enabled.
Changeset
Altered the plugin so that only the setup for the proguard mapping file task is skipped if a variant has obfuscation disabled.
Tests
Ran
./gradlew assemblein a project withminifyEnabled falseusing the current version of the plugin and then a local artefact. I visually inspected the gradle console and confirmed that the NDK upload task was run.