Extract SO files from bugsnag-android artefact #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kattrali
suggested changes
Jun 3, 2019
Co-Authored-By: Delisa <kattrali@users.noreply.github.com>
kattrali
approved these changes
Jun 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
The gradle plugin should extract shared object files from both the bugsnag-android and bugsnag-android-ndk artefacts, as in the future both will contain native bugsnag code that is required by C end-users.
Changeset
Expanded artefact filter so that files are extracted for both bugsnag-android and bugsnag-android-ndk.
Tests
Verified that an example project requiring the NDK can be built with bugsnag-android and a local installation of this changeset.