Add ability to override reported value for versionCode #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t.bugsnag.versionCode or manife
fractalwrench
changed the title
tomlongridge
reviewed
Oct 9, 2019
src/main/groovy/com/bugsnag/android/gradle/BugsnagVariantOutputTask.groovy
Outdated
Show resolved
Hide resolved
tomlongridge
approved these changes
Oct 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Allows overriding the
android:versionCodevalue reported via the manifest when uploading mapping files toupload.bugsnag.com. This can be overridden by addingcom.bugsnag.android.VERSION_CODEas ameta-dataelement in the manifest.For further context see bugsnag/bugsnag-android#610
Changeset
Search the manifest first for the value of
com.bugsnag.android.VERSION_CODE, and then for the value ofandroid:versionCode.Deprecated
bugsnag.apiKey.Tests
versionCodeis set correctly in 2 cases: setting via the manifest; and setting via the plugin extension