Make upload tasks support up-to-date checks #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fractalwrench
force-pushed
the
v5-upload-tasks
branch
from
f160c92
to
f4ab046
Compare
fractalwrench
changed the title
fractalwrench
force-pushed
the
v5-upload-tasks
branch
3 times, most recently
from
eb3537c
to
780eae0
Compare
fractalwrench
force-pushed
the
v5-upload-tasks
branch
from
780eae0
to
720677a
Compare
imjoehaines
approved these changes
Jul 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Adds the mapping file as an input to the
BugsnagUploadProguardTask, and an output file for each upload request that writes the result of the request. This enables up-to-date checks on all the upload tasks as their inputs/outputs are explicitly defined.Changeset
packagevalue from the android manifest, as this allows tasks to avoid reading the information from theApkVariant, leading to an ultimate removal of these fields from the tasksProvider<RegularFile>which finds the mapping file. This is set as an input property on the proguard upload tasksOutputFileproperty where the response information is written for each task, enabling up-to-date checksmissing_mapping_filescenario as the scenario is contrived and should not happen in a real appTests
Relied on existing E2E test coverage. Verified that the upload tasks were shown as up-to-date when building an example app for the second time, and that altering the
buildUuidin the manifest invalidated this.