Deduplicate unnecessary upload requests for APK splits #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fractalwrench
force-pushed
the
v5-request-dedupe
branch
from
3f70d64
to
6211133
Compare
fractalwrench
force-pushed
the
v5-request-dedupe
branch
4 times, most recently
from
4d287d5
to
36bb403
Compare
fractalwrench
force-pushed
the
v5-request-dedupe
branch
from
36bb403
to
e03ddd1
Compare
fractalwrench
changed the title
fractalwrench
force-pushed
the
v5-request-dedupe
branch
from
e03ddd1
to
17d1a40
Compare
fractalwrench
force-pushed
the
v5-request-dedupe
branch
from
17d1a40
to
9fa0b43
Compare
imjoehaines
approved these changes
Aug 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Deduplicates unnecessary upload requests for APK splits. For each APK split if the mapping file and version information is the same, then the upload is skipped if a request has already been enqueued.
Changeset
Added
UploadRequestClient, which takes anAndroidManifestInfoand payload to calculate a unique request hash. If the request hash already exists, the enqueued request's response is retrieved. If no request already exists for a hash, a request is enqueued and its response is stored for future use.A separate
UploadRequestClienthas been created for the Release/JVM/NDK APIs, to avoid the unlikely possibility of any hash collisions.Tests
UploadRequestClient