Support mapping upload from Android Gradle Plugin through a proxy #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cawllec
force-pushed
the
tests-ordering
branch
from
d652927
to
b3285fb
Compare
fractalwrench
force-pushed
the
PLAT-4890/proxy-support
branch
4 times, most recently
from
0cdf6c1
to
a2b86a9
Compare
fractalwrench
force-pushed
the
PLAT-4890/proxy-support
branch
2 times, most recently
from
0b22bef
to
1e0cc88
Compare
fractalwrench
force-pushed
the
PLAT-4890/proxy-support
branch
2 times, most recently
from
f38a9bd
to
039deb2
Compare
fractalwrench
force-pushed
the
PLAT-4890/proxy-support
branch
from
039deb2
to
10f7ee1
Compare
fractalwrench
force-pushed
the
PLAT-4890/proxy-support
branch
3 times, most recently
from
2d5bff4
to
8c532ad
Compare
fractalwrench
force-pushed
the
PLAT-4890/proxy-support
branch
from
8c532ad
to
82f9842
Compare
imjoehaines
requested changes
Sep 18, 2020
src/main/kotlin/com/bugsnag/android/gradle/internal/BugsnagHttpClientHelper.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/com/bugsnag/android/gradle/internal/BugsnagHttpClientHelper.kt
Outdated
Show resolved
Hide resolved
Co-authored-by: Joe Haines <hello@joehaines.co.uk>
imjoehaines
reviewed
Sep 18, 2020
src/main/kotlin/com/bugsnag/android/gradle/internal/BugsnagHttpClientHelper.kt
Outdated
Show resolved
Hide resolved
…pClientHelper.kt Co-authored-by: Joe Haines <hello@joehaines.co.uk>
imjoehaines
approved these changes
Sep 18, 2020
This was referenced Sep 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Adds support for uploading mapping files with the plugin through a proxy.
This changeset is based off #275 and will add automated test coverage.
Changeset
BugsnagHttpClientHelperto read the JVM networking properties when creating a new HTTP clientproxyHost/proxyPortare set, construct a newProxyand set it onOkHttpClient.Builder#proxyproxyUser/proxyPassare set, create an authenticator and set it onOkHttpClient.Builder#proxyAuthenticatorTests
Adds E2E scenarios that the plugin can route requests through a local HTTP proxy, with and without credentials.
The test fixture has supplied the proxy information through JVM arguments, rather than in the
gradle.properties, as this simplifies testing and is functionally equivalent.