Fix task ordering for upload task on AGP 3.5 #300
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Fixes the task ordering for the bugsnag upload tasks to enforce that it must run after the package task which produces the APK/AAB. This dependency was not explicitly specified and resulted in the JVM upload task failing with the following exception:
This was caused by the fact that the JVM upload task on AGP 3.5 executed before the package task, and so the mapping file was not present. Explicitly adding a task ordering fixes this issue.
Changeset
BugsnagPlugin
pass whether the task has been configured to run automatically tovariant.register()
registerAgp3/registerAgp4
methods as these do not have any function and appear to throw an exception on all tested AGP versions, resulting in a default fallback toregisterManual
registerManual
task dependencies in theautoRunTask
flag, and configure the upload task to run automatically if required. This follows a similar approach to that taken in Fix task dependencies and order for BugsnagManifestUuidTask in AGP <4.1.0 #294Testing
Enabled skipped E2E scenarios for AGP 3.5.