Generate shared object mapping files in separate class #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fractalwrench
force-pushed
the
PLAT-4965/shared-object-factory
branch
from
46f94d2
to
1b1c125
Compare
imjoehaines
approved these changes
Sep 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Refactors the generation of shared object mapping files into a separate factory class.
This creates a new class named
SharedObjectMappingFactorywhich generates a mapping file for a given shared object. This will make it easier to create different mapping files for NDK vs Unity SO files, and avoids any new Unity Gradle task needing to rely on code withinBugsnagGenerateNdkSoMappingTask.The implementation has remained the same with the exception that a
SharedObjectMappingFileFactory.Paramsclass has been added, and that the architecture is supplied asAbirather thanString.Testing
Relied on existing E2E test coverage as this does not involve any functional changes.