Support Unity builds using internal Gradle #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fractalwrench
force-pushed
the
PLAT-4967/support-internal-build
branch
3 times, most recently
from
4b86b38
to
8dddd15
Compare
fractalwrench
force-pushed
the
PLAT-4967/support-internal-build
branch
from
8dddd15
to
1fd04ab
Compare
imjoehaines
approved these changes
Oct 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
It's possible to build a Unity project either by exporting symbols to an archive, which is supported, or by using Unity's internal Gradle build. This changeset adds support for uploading Unity SO mapping files for the second use case.
Changeset
Temp/StagingArea/symbolsdirectory forlibunity/libil2cppSO filesTemp/StagingArea/symbolsdirectoryTesting
Manually tested on a Unity 2018 and 2019 example project and confirmed that a SO mapping file was generated in the appropriate build directory. Due to the nature of the change E2E tests were not seen as feasible on CI for now and manual testing was agreed as part of the design.