Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove previous files from intermediate build directory #318

Merged

Conversation

fractalwrench
Copy link
Contributor

@fractalwrench fractalwrench commented Oct 2, 2020

Goal

Removes previous files from an intermediate build directory, which could cause erroneous uploads if a SO file had been moved on the filesystem. Additionally this changeset prevents libunity.so, libil2cpp.so, and libmain.so from being

Changeset

The gradle plugin copies SO files to an intermediate build directory to take advantage of gradle's task caching.

If a build occured, an SO file was removed/renamed in the project, and then another build occurred, the removed/renamed SO file incorrectly remains in the build directory and is uploaded. The fix for this is to clear out the directory when running the task, which is done for both the Unity/NDK generation tasks.

Additionally, the BugsnagGenerateNdkSoMappingTask tries to generate NDK mapping files for libunity/libmain/libil2cpp, which have been ignored to avoid spamming the build log with the following warning:

Bugsnag: Skipping upload of empty/invalid mapping file: intermediates/bugsnag/soMappings/ndk/armeabi-v7a/libunity.so.gz

Testing

Manually verified that no warning is present in the build log, and that only the relevant files are copied to the intermediate directory on a build that uses cache.

@fractalwrench fractalwrench marked this pull request as ready for review October 2, 2020 13:07
@fractalwrench fractalwrench merged commit 68ce1c5 into proj-symbolicate-android-unity Oct 2, 2020
@fractalwrench fractalwrench deleted the PLAT-5170/unity-bug-fixes branch October 2, 2020 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants