Remove previous files from intermediate build directory #318
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Removes previous files from an intermediate build directory, which could cause erroneous uploads if a SO file had been moved on the filesystem. Additionally this changeset prevents
libunity.so
,libil2cpp.so
, andlibmain.so
from beingChangeset
The gradle plugin copies SO files to an intermediate build directory to take advantage of gradle's task caching.
If a build occured, an SO file was removed/renamed in the project, and then another build occurred, the removed/renamed SO file incorrectly remains in the build directory and is uploaded. The fix for this is to clear out the directory when running the task, which is done for both the Unity/NDK generation tasks.
Additionally, the
BugsnagGenerateNdkSoMappingTask
tries to generate NDK mapping files forlibunity/libmain/libil2cpp
, which have been ignored to avoid spamming the build log with the following warning:Testing
Manually verified that no warning is present in the build log, and that only the relevant files are copied to the intermediate directory on a build that uses cache.