JNI install task should always takes place if NDK build enabled #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fractalwrench
force-pushed
the
PLAT-5205/jni-install-task
branch
from
a66771d
to
35e6bac
Compare
imjoehaines
approved these changes
Oct 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
In v4 of the plugin the
BugsnagInstallJniLibsTaskalways ran if the NDK build was active, as users may need to copy bugsnag's SO files to their build directory so that they can link against them. v5 introduced a bug where this was gated behind theuploadNdkMappingsflag - this changeset corrects this change so that the user's project is always able to link against theTesting
Manually verified in an example app that the task runs regardless of the value of
uploadNdkMappings. E2E tests were not considered practical as there aren't any existing steps to address this, and the functionality of copying SO files will soon be superseded by improvements to AGP's support for external native dependencies (PLAT-3171)