Replace Groovy XML library used for parsing AndroidManifest.xml #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fractalwrench
force-pushed
the
PLAT-6294/gradle-7-compat
branch
from
bed0b23
to
982fc75
Compare
fractalwrench
force-pushed
the
PLAT-6294/gradle-7-compat
branch
from
982fc75
to
d99510c
Compare
fractalwrench
changed the title
imjoehaines
reviewed
Apr 1, 2021
|
It looks like there is a bug in the RN CLI gradle script which affects Gradle 7, and causes the test fixtures to immediately throw an exception: react-native-community/cli#1396 I will update our E2E tests to skip the react-native tests until this is resolved as there isn't a workaround. |
imjoehaines
approved these changes
Apr 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Gradle 7 updated the language it uses to Groovy 3. Part of the changes in Groovy 3 involved a reorganisation of packages which affected the classes used for XML parsing, which results in
NoSuchMethodErrorbeing thrown when running the plugin on Gradle 7.To avoid this behaviour the plugin has been updated to use a Java XML parser instead.
Resolves #369
Changeset
Refactored
AndroidManifestParserto use an XML parser supplied via Java instead.Testing
Updated test matrix to run E2E tests against Gradle 7.0-rc-1, and added to unit test coverage.