Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clearer error messages if the node_modules directory is not found #410

Merged
merged 1 commit into from
Jul 23, 2021

Conversation

lemnik
Copy link
Contributor

@lemnik lemnik commented Jul 22, 2021

Goal

Emit a clear error message when the node_modules directory cannot be located by the plugin, or if the Bugsnag react-native module cannot be found. Previously the plugin would create an invalid Maven reference, potentially leading to compiler errors.

Testing

Manually tested by removing the node_modules directory and running the Gradle build

…e Bugsnag react-native modules cannot be found
Copy link
Contributor

@fractalwrench fractalwrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lemnik lemnik changed the base branch from v7/master to v7/next July 23, 2021 07:28
@lemnik lemnik merged commit e1f4ecd into v7/next Jul 23, 2021
@lemnik lemnik deleted the PLAT-7038/missing-node_modules-error-v7 branch July 23, 2021 07:46
lemnik added a commit that referenced this pull request Aug 12, 2021
* fix(react-native): add clear error messages when `node_modules` or the Bugsnag react-native modules cannot be found (#410)

* chore: replace all references of "7.0.0-beta04" with "7.0.0" (#415)

* Release v7.0.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants