AGP 7.2 support #464
Merged
AGP 7.2 support #464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r a File or DirectoryProperty
kattrali
reviewed
May 19, 2022
src/main/kotlin/com/bugsnag/android/gradle/internal/ExternalNativeBuildTaskUtil.kt
Show resolved
Hide resolved
lemnik
force-pushed
the
PLAT-8460/agp-7.2-support
branch
from
a58e24b
to
8912898
Compare
kattrali
approved these changes
May 19, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Basic support for Android Gradle Plugin 7.2.
Design
ExternalNativeBuildTask.soFolderandobjFolderreturnFilein AGP 7.0 andDirectoryPropertyin 7.2. To work around this we now use reflection on these properties and handle either case based on the returned value.This PR also includes a change to the test fixture, using
sedto alter thegradle-wrapper.propertiesavoiding versioning problems with thegradle wrappertask (which can have conflicts between the Gradle version and AGP version intended to be tested).Testing
New test pipeline for AGP 7.2 using existing fixtures.