Fix search path for ndkBuild #478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kattrali
approved these changes
Sep 22, 2022
lemnik
force-pushed
the
PLAT-8946/fix-empty-so-for-ndkBuild
branch
from
a81d8cd
to
0d5544c
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Avoid generating empty mapping files (or no mapping file) when
ndkBuildis used.Changelog
ndkBuildgenerates an additional directory level (typically namedlocal) between the expectedobjdirectory and the architecture directory. This change looks for thecxxdirectory two or three levels above the directory reported fromExternalNativeBuildTask.Testing
Added support for
ndkBuildto the existingndktest fixture, and a test scenario to go with it.