Fix FileAlreadyExistsException in v7 when using ReactNative & Hermes #482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lemnik
force-pushed
the
PLAT-7741/fix-file-already-exists
branch
from
e0e4ce9
to
b1309f4
Compare
tomlongridge
approved these changes
Oct 31, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Fix
FileAlreadyExistsExceptionduring ReactNative builds using Hermes by ensuring that existing source-maps are overwritten instead of causing build failures.Testing
Tested manually by reproducing the error as described, and then testing that the fix no-longer causes the same issue. Instead the source maps are now overwritten and the new source maps are uploaded.