Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DexGuard version config option #531

Merged
1 commit merged into from
Aug 1, 2023

Conversation

ghost
Copy link

@ghost ghost commented Jul 21, 2023

Goal

Fix builds for users of DexGuard 9.4+

Design

Due to the DexGuard 9.4+ Gradle plugin no longer having a VERSION property, default to DexGaurd 9 behaviour when DexGuard is being used.

Users of earlier versions can use:

bugsnag.dexguardMajorVersion = 8

to revert to DexGuard 8 compatible behaviour.

Testing

Tested manually with DexGuard version 9.4 and DexGuard 8

@ghost ghost force-pushed the PLAT-10620_Add_DexGuard_version_config_option branch from a836e12 to 36e459d Compare July 21, 2023 13:12
@ghost ghost requested a review from lemnik July 21, 2023 14:07
Copy link
Contributor

@lemnik lemnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghost ghost merged commit e7abd92 into next Aug 1, 2023
1 check passed
@ghost ghost deleted the PLAT-10620_Add_DexGuard_version_config_option branch August 1, 2023 13:50
@ghost ghost restored the PLAT-10620_Add_DexGuard_version_config_option branch August 1, 2023 14:03
This was referenced Sep 27, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants