Strictmode fixes #413
Merged
Strictmode fixes #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
on initialisation calculateFreeDisk was indirectly invoked, which performs IO on the main thread. This change avoids calls to getDeviceData() which would trigger these calculations, and adds getters for the necessary fields instead. This stops StrictMode violations being reported when initialising the SDK.
JUnit offers a RunListener, which has a method that is invoked after each test is completed. Specifying this is preferable to using @after for teardown, as we can cancel asynchronous tasks from one place only in this manner.
By default, we should cache the result of whether the device is rooted or not, as the result is unlikely to change between app launches and the calculation requires IO.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integration branch for #409, #410, and #411